Show Folder Sizes and Folder View Settings

[admin]

Try v19.50.0238 ...

[elqasar2]

It's looking much better, thanks. I'm in the early stages of testing, but it looks like it's working well when switching between my FVS and non-FVS tabs in the same pane. In this case, they are not interfering with each other as far as I can tell.

But what is not working is dual panes in this regard. When I have Pane 2 active, with a tab pointing to a non-FVS folder, and Pane 1 inactive with a FVS folder visible, then turning on a setting like Show Folder Sizes in Pane 2 (the active pane) causes that setting to spread across to Pane 1 (the inactive pane) where the FVS tab is visible.

[admin]

Confirmed, I'll upload a fix soon.

[elqasar2]

It looks to be fixed in 19.50.0239. But there is a different bug I'm looking at now:

If you have the same FVS tab visible in both panes, and then turn on a setting such as Show Folder Sizes, the change only occurs in the active pane. When you switch over to the inactive pane, the setting hasn't taken effect there. Even if in that pane you then go somewhere else and then come back to the FVS folder, the setting still doesn't take effect. So what you end up with is the 2 panes being out of sync, even when viewing the same FVS folder.

Edit: In fact, that FVS folder doesn't even have to be visible at the same time in the inactive pane. Even if it's not visible, and you browse to it later in the second pane, it is still out of sync. It is as if the FVS is now being saved not only per-location but also per-pane.

[admin]

Whoops, sure. But we're coming closer...

[elqasar2]

Also, Tabsets is affected - not sure if it's because of the recent changes, or if it's always been this way.

According to what I read in the help, Tabsets are supposed to save all the tab settings and list settings of each tab.

But if I do this:

1. Load a tabset where the global (non-FVS) setting for Show Folder Sizes is off.
2. Enable Show Folder Sizes on a non-FVS tab.
3. Restore the tabset (Revert to Saved).

Notice that Show Folder Sizes remains on. I would expect it to revert to what that setting was (off) when the tabset was saved.

[admin]

Try v19.50.0240 ...

[elqasar2]

Have only tested for 1 minute so far with 19.50.0240, but I already see that enabling Show Folder Sizes on one of my FVS folders in the one pane, applies that same change immediately to a different FVS folder that is visible in the other pane.

Edit: Actually, it appears that it applies the same change immediately to all tabs in the other pane, no matter whether they are a different FVS or even a non-FVS.

[admin]

Okay, I'm back on this tomorrow...

[admin]

This is the state in v19.50.0241 when "Apply list styles globally" is ON:

Code: Select all

                             Spreads to: 
                               Normal tab    FVS tab    FVS-AutoSave tab 
      Style change in:       ----------------------------------------------
        Normal tab           |    +            -             -             
        FVS tab              |    +            -/+           -             
        FVS-AutoSave tab     |    -            -             -/+    
        
        -/+ means: It spreads if the tab uses the *same* FVS as the source tab.       

There is an obvious asymmetry: Changes in FVS tabs spread to normal tabs. Is that desired? Or should we simplify the picture like this:

Code: Select all

                             Spreads to: 
                               Normal tab    FVS tab 
      Style change in:       ------------------------
        Normal tab           |    +            -     
        FVS tab              |    -            -/+   
        
        -/+ means: It spreads if the tab uses the *same* FVS as the source tab.       

[admin]

Well, I meditated on this for 5 hours and decided: YES, let's simplify it!

[elqasar2]

I agree with the simplified, second table.

The first table doesn't make sense, anyway, as Folder Views are saved per-location, so as far as I know you can't have both a FVS and FVS-Autosave associated with the same location anyway (or at least you shouldn't be able to). So you'd never need to think about whether a change would need to affect the FVS and the FVS-Auotosave for the same location because that location can only have one or the other, not both.

I'll try out 19.50.0241 later this evening if I can.

[elqasar2]

I've had a chance to try 19.50.0241, and so far it's looking very good.

The improvements made to FVS yesterday and today make a HUGE difference, and the functionality of FVS is now much more predictable and useful than before!

[admin]

Thanks for thorough and relentless reporting! The way to go.