Go up doesn't honor scroll margin

Things you’d like to miss in the future...
LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Go up doesn't honor scroll margin

Post by LittleBiG »

Double click on the free space goes up, but the selection will stand on the first file of the list, instead of the ScrollMargin+1. I would expect that, because I still want to see what is above.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Go up doesn't honor scroll margin

Post by admin »

I agree. Comes with next beta.

LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Go up doesn't honor scroll margin

Post by LittleBiG »

Thanks it works great. However, is it possible that the Go Back doesn't honor this? Let me show you why I am saying this. I have Scroll Margin=15 to keep everything in the almost middle (especially for the tree, but there is no separate option for it) and History retains selection is ticked. When I click "Go back" in the video, the selection will be restored (even with the proper place), then after half a second it is scrolled up in order to obey the scroll margin, which I didn't want. (Additionally it is possible to scroll away in this half a second if I am too fast.) In my opinion, the jump because of the scroll margin is completely unnecessary and unwanted too, with the retain selection option especially.
Attachments
GoBackScroll.gif
GoBackScroll.gif (314.69 KiB) Viewed 1689 times

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Go up doesn't honor scroll margin

Post by admin »

Somehow I cannot reproduce this. Many settings can influence this. It might be an unsolvable conflict.

LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Go up doesn't honor scroll margin

Post by LittleBiG »

:(
By the way, the actual folder always scrolls into view in the tree on startup. (The selected file in the list can remain ourtside, according to the last state of the list.) Have you hard-coded the scroll margin to 2 in this case?

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Go up doesn't honor scroll margin

Post by admin »

Really? Not here. Must be some setting...

LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Go up doesn't honor scroll margin

Post by LittleBiG »

I have started to scrutinize each ini entry which was related to the tree. it is unbelievable, but I was lucky, I have found the culprit: the RestoreMaxiTree was set to 0. When I set to 1, it became ok. What is this setting for?? I didn't find info in the changelog. Actually I always use Mini Tree.

Edit: ok, I find out: this is the Configuration/Tree and List/Remember state of tree option. So, when it is unticked, please ensure that the scroll margin be honored. (It look as it is hard-coded to 2)

Additionally: it is not too logical. To remember the tree state is in the Tree and List, and to remember the list state of list is in The Startup&Exit/Remember Most recently Used List..., and it is called "Focused Item and Scroll Position of Tabs" Jeeeez...

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Go up doesn't honor scroll margin

Post by admin »

Yes, fix comes.

You are having a monstruous run... :maf: :tup:

LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Go up doesn't honor scroll margin

Post by LittleBiG »

Still hard-coded to 2. Maxi and mini tree also.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Go up doesn't honor scroll margin

Post by admin »

Indeed, confirmed for Mini Tree.

LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Go up doesn't honor scroll margin

Post by LittleBiG »

:-( Now the state is always remembered, no matter how the option is set.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Go up doesn't honor scroll margin

Post by admin »

Which configuration does not work as expected?

LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Go up doesn't honor scroll margin

Post by LittleBiG »

admin wrote:Which configuration does not work as expected?
Ok, I understand, that you call it RestoreMaxiTree under the hood. But the option name is "Remember state of tree" I am just wondering why it is not used for Mini Tree. This option is not something what can be meaningful only for maxi tree. I expected the same working. The other options under the tree section also work for both trees.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Go up doesn't honor scroll margin

Post by admin »

Again, what does not work as expected?

LittleBiG
Posts: 1846
Joined: 08 Apr 2011 12:57
Location: Win10x64

Re: Go up doesn't honor scroll margin

Post by LittleBiG »

admin wrote:Again, what does not work as expected?
When the "Remember state of tree" in the Configuration/Tree and List unticked, the Mini Tree does remember its state, and doesn't scroll the current folder into view on startup.

Post Reply