Custom Columns Broke after 17.80.0001

Things you’d like to miss in the future...
Post Reply
nerdweed
Posts: 593
Joined: 25 Feb 2012 07:47

Custom Columns Broke after 17.80.0001

Post by nerdweed »

Hi Don,

I had some custom columns like this

Code: Select all

If ($CC_DATA UnLike "<cc_path>|*" || $CC_DATA Like "<cc_path>|<cc_base><crlf>*")
{
 perm $CC_DATA = "<cc_path>|<cc_base><crlf>" . replace(runret("cmd /c sqlite3.exe Wally.db ""SELECT file, tag, rating FROM vw_files WHERE file like '<cc_path>%' and file not like '<cc_path>%\%' and (rating > 0 or tag_id > 0)""", $PIC_HOME),<cc_path>);
}
return trim(gettoken(formatlist("$CC_DATA", "f", "<crlf>", "<cc_name>|*"), 2, "|", ,2), "|", "LR");
This stuff doesn't return any value since 17.80.0001.

I think the below change somehow broke it
+ Custom Columns | Script: Now user functions are supported right in the
column scripts. So TheQwerty can now use crazy scripts like this:
------------------------------------
function A() { return 'A'; }
function C() { return B() . 'C'; }
function B() { return A() . 'B'; }

return C() . 'D';
------------------------------------
Also, the below change is counter productive. This should be called reset and added as new (if it still's needed), but the refresh should remain.I use the above custom column as click based trigger. After I tag the files in SQLite, I refresh it to see if they have been added and refresh was the way to do it.
Custom Columns: Experimentally a Refresh Column on columns with trigger
"Click" now restores the Click icon. Before, it processed a fake click for
each item in the list.
Kindly check this, I have had to rollback to 17.80 because of this.. not something I do very often.

Edit: some missing piece of code added.
Last edited by nerdweed on 25 Mar 2017 04:05, edited 2 times in total.

admin
Site Admin
Posts: 49995
Joined: 22 May 2004 16:48
Location: Cologne, Win 8.1, Win 10
Contact:

Re: Custom Columns Broke after 17.80.0001

Post by admin »

1. Cannot see how this could be related to that change. :?

2. I'll check that.
FAQ | XY News RSS | XY Twitter | Stay home! 🎸 Or wear a mask! 😷

nerdweed
Posts: 593
Joined: 25 Feb 2012 07:47

Re: Custom Columns Broke after 17.80.0001

Post by nerdweed »

Thanks for reverting back the refresh related change.

Regarding the other issue, the custom column was incomplete in the original post, but it should have still returned data just consuming more cycles (corrected in OP regardless).

I initially thought that it might be related to functions, but found the culprit now. <cc_path> doesn't resolve now

Code: Select all

return <cc_path>
The above code returns <cc_path> unresolved.

admin
Site Admin
Posts: 49995
Joined: 22 May 2004 16:48
Location: Cologne, Win 8.1, Win 10
Contact:

Re: Custom Columns Broke after 17.80.0001

Post by admin »

Oh, thanks! Fix comes.
FAQ | XY News RSS | XY Twitter | Stay home! 🎸 Or wear a mask! 😷

Post Reply