Undo/Redo

Things you’d like to miss in the future...
jacky
XYwiki Master
Posts: 3106
Joined: 23 Aug 2005 22:25
Location: France
Contact:

Re: Undo/Redo

Post by jacky »

Not really a bug, maybe more of a wish for Undo 2.0 I guess...

I know that the AL/Undo/Redo is meant for file operations, but I would really like to see it "expanded" to a few more actions. Yes, XY-specific actions, but let's be honest all actions logged are XY-specific already, in that they need to occur within XY obviously. And while part of XY and not affecting the files (read: items, files and folders, but w/e) themselves/directly, I still consider them to be file operations as well.

I am talking about things like Tags & Comments, but also Highlighted Folders & Boxed Branches. I also realize that it might not have been planned and, unlike other operations logged where only two arguments are saved, here we would need a third (since we have original state (tag, highlight color, comment, etc to restore/undo to), new state in addition to, of course, the items names), but AFAIC when I set a tag to a file, it is as much a file operation as it as when I rename said file, and part of my work flow has me using tags, highlighted folders or comments as in integral part of my system. I appreciate that when I move a file its tags/comments move along, and that when I undo the move operation they move back with it as well.

But I would also really like it if after setting a file to tag "red" only to realize it was a mistake, I could simply hit Undo and it would switch back to "orange" -- because as I said, to me, changing a tag, comment or highlight color falls under the same category of file operations as does renaming or moving it. Those are file operations as well, and ones I would love to see logged & be able to undo/redo.
Proud XYplorer Fanatic

j_c_hallgren
XY Blog Master
Posts: 5824
Joined: 02 Jan 2006 19:34
Location: So. Chatham MA/Clearwater FL
Contact:

Re: Undo/Redo

Post by j_c_hallgren »

Finally catching up with the rest of the gang here... :oops:

Hadn't installed any of the undo/redo betas till today...so did so and as my first test, did a simple delete of a JPG to get something in the Action Log...but what I'm puzzled by is the section at bottom which seems to be for showing the weird internal name in the RB yet on mine, it showed as "(unknown)"...huh? :?

XY was able to recover it fine but I was expecting it to have "Dc24418.jpg" there as XY has when I view the RB itself.
Still spending WAY TOO much time here! But it's such a pleasure helping XY be a treasure!
(XP on laptop with touchpad and thus NO mouse!) Using latest beta vers when possible.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Undo/Redo

Post by admin »

j_c_hallgren wrote:Finally catching up with the rest of the gang here... :oops:

Hadn't installed any of the undo/redo betas till today...so did so and as my first test, did a simple delete of a JPG to get something in the Action Log...but what I'm puzzled by is the section at bottom which seems to be for showing the weird internal name in the RB yet on mine, it showed as "(unknown)"...huh? :?

XY was able to recover it fine but I was expecting it to have "Dc24418.jpg" there as XY has when I view the RB itself.
On Win 2K, right?

Not sure yet, what's happening. The same issue is seen in Vista/Win7 apparently. I'm right now researching it. The next version will do some internal logging. You can see the log by using <get debuglog>. For example when I delete a file (to recycler) and then run the script

Code: Select all

text "<get debuglog>";
I see the following output:

Code: Select all

14:35:41.431 >> 4: E:\ClipSpy.rc¿
14:35:41.451 >> SHCNE_DELETE
14:35:41.451 >> SHCNE_DELETE: E:\ClipSpy.rc | ClipSpy.rc | E:\RECYCLER\S-1-5-21-1606980848-492894223-854245398-1003\De3497.rc | De3497.rc
14:35:41.451 >> mod 4: E:\ClipSpy.rc|E:\RECYCLER\S-1-5-21-1606980848-492894223-854245398-1003\De3497.rc
14:35:41.451 >> SHCNE_DELETE
14:35:41.451 >> SHCNE_DELETE: E:\ClipSpy.rc | ClipSpy.rc | E:\RECYCLER\S-1-5-21-1606980848-492894223-854245398-1003\De3497.rc | De3497.rc
14:35:41.451 >> mod 4: E:\ClipSpy.rc|E:\RECYCLER\S-1-5-21-1606980848-492894223-854245398-1003\De3497.rc
Please, with the next version, try this...

j_c_hallgren
XY Blog Master
Posts: 5824
Joined: 02 Jan 2006 19:34
Location: So. Chatham MA/Clearwater FL
Contact:

Re: Undo/Redo

Post by j_c_hallgren »

admin wrote:
j_c_hallgren wrote:XY was able to recover it fine but I was expecting it to have "Dc24418.jpg" there as XY has when I view the RB itself.
On Win 2K, right?
Please, with the next version, try this...
Yes, I'm the obsolete W2K guy... :roll: Hey, at least you have someone to check it! :lol:
And will try that on next vers and let you know what I get... 8)
Still spending WAY TOO much time here! But it's such a pleasure helping XY be a treasure!
(XP on laptop with touchpad and thus NO mouse!) Using latest beta vers when possible.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Undo/Redo

Post by admin »

OK, here's part 2 of it, for the Vista/Win7 crowd. After you tried to restore such an item with "unknown" recycle bin name, do again

Code: Select all

text "<get debuglog>";
. Then you should see something like this:

Code: Select all

14:52:33.826 >> rd 0: Name = StdAfx.h
14:52:33.826 >> rd 1: Ursprung = E:\VB-Don\TestFiles\Temp\Aa231xy\a
14:52:33.826 >> rd 2: Löschdatum = 24.10.2009 16:50
14:52:33.826 >> rd 3: Größe = 4 KB
14:52:33.826 >> rd 4: Typ = H-Datei
14:52:33.826 >> rd 5: Geändert am = 27.09.2001 12:44
14:52:33.826 >> rd 6: Erstellt am = 24.10.2009 16:50
14:52:33.826 >> rd 7: Letzter Zugriff am = 24.10.2009 16:50
14:52:33.826 >> rd 8: Attribute = A
14:52:33.826 >> rd 9: Status = Online
14:52:33.826 >> rd 10: Besitzer = COBY\Donald
Please let me know how this looks under Vista/Win7, thanks! (In the next version, upload within about 1 hour).

j_c_hallgren
XY Blog Master
Posts: 5824
Joined: 02 Jan 2006 19:34
Location: So. Chatham MA/Clearwater FL
Contact:

Re: Undo/Redo

Post by j_c_hallgren »

admin wrote: Then you should see something like this:

Code: Select all

14:52:33.826 >> rd 0: Name = StdAfx.h
14:52:33.826 >> rd 1: Ursprung = E:\VB-Don\TestFiles\Temp\Aa231xy\a
14:52:33.826 >> rd 2: Löschdatum = 24.10.2009 16:50
14:52:33.826 >> rd 3: Größe = 4 KB
14:52:33.826 >> rd 4: Typ = H-Datei
I would hope that my system doesn't suddenly start speaking German! :lol:

It just struck me as funny...I know what you meant anyway.. :mrgreen:
Still spending WAY TOO much time here! But it's such a pleasure helping XY be a treasure!
(XP on laptop with touchpad and thus NO mouse!) Using latest beta vers when possible.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Undo/Redo

Post by admin »

j_c_hallgren wrote:
admin wrote: Then you should see something like this:

Code: Select all

14:52:33.826 >> rd 0: Name = StdAfx.h
14:52:33.826 >> rd 1: Ursprung = E:\VB-Don\TestFiles\Temp\Aa231xy\a
14:52:33.826 >> rd 2: Löschdatum = 24.10.2009 16:50
14:52:33.826 >> rd 3: Größe = 4 KB
14:52:33.826 >> rd 4: Typ = H-Datei
I would hope that my system doesn't suddenly start speaking German! :lol:

It just struck me as funny...I know what you meant anyway.. :mrgreen:
Sorry, I know that vowels with 2 dots flying overhead look very frightening to Americans. Relax, they are usually harmless. :wink:

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Undo/Redo

Post by admin »

So, did anybody try the debuglog? Or are there questions as to how to use it?

j_c_hallgren
XY Blog Master
Posts: 5824
Joined: 02 Jan 2006 19:34
Location: So. Chatham MA/Clearwater FL
Contact:

Re: Undo/Redo

Post by j_c_hallgren »

admin wrote:So, did anybody try the debuglog? Or are there questions as to how to use it?
Well, you said twice "next" vers and I'd not seen any indication that was ready/available...you didn't post here or in beta...so how was I to know? Did you just hotfix replace the last beta?
Still spending WAY TOO much time here! But it's such a pleasure helping XY be a treasure!
(XP on laptop with touchpad and thus NO mouse!) Using latest beta vers when possible.

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Undo/Redo

Post by admin »

j_c_hallgren wrote:
admin wrote:So, did anybody try the debuglog? Or are there questions as to how to use it?
Well, you said twice "next" vers and I'd not seen any indication that was ready/available...you didn't post here or in beta...so how was I to know? Did you just hotfix replace the last beta?
Hmmm, looks like I forgot to update that thread... something must have distracted me, probably the miserable performance of our local football club, argh.

TheQwerty
Posts: 4373
Joined: 03 Aug 2007 22:30

Re: Undo/Redo

Post by TheQwerty »

On Vista x64:

Delete:

Code: Select all

21:28:02.134 >> 4: Z:\New Folder-01¿
21:28:02.179 >> SHCNE_MKDIR
21:28:02.179 >> SHCNE_MKDIR: Z:\$RECYCLE.BIN\S-1-5-21-1228544555-2450258989-2244176320-1000\$RXJOFIF | $RXJOFIF |  | 
21:28:02.180 >> SHCNE_RMDIR
21:28:02.180 >> SHCNE_RMDIR: Z:\New Folder-01 | New Folder-01 |  | 
21:28:02.180 >> SHCNE_MKDIR
21:28:02.180 >> SHCNE_MKDIR: Z:\$RECYCLE.BIN\S-1-5-21-1228544555-2450258989-2244176320-1000\$RXJOFIF | $RXJOFIF |  | 
After Undo Failed:

Code: Select all

21:28:25.782 >> rd 0: Name = New Folder-01
21:28:25.782 >> rd 1: Original Location = Z:\
21:28:25.782 >> rd 2: Date Deleted = ?10/?24/?2009 ??5:28 PM
21:28:25.783 >> rd 3: Size = 0 bytes
21:28:25.783 >> rd 4: Type = File Folder
21:28:25.783 >> rd 5: Date modified = ?10/?24/?2009 ??5:27 PM
21:28:25.783 >> rd 6: Date created = ?10/?24/?2009 ??5:27 PM
21:28:25.783 >> rd 7: Date accessed = ?10/?24/?2009 ??5:27 PM
21:28:25.783 >> rd 8: Attributes = 
21:28:25.783 >> rd 9: Offline status = 
21:28:25.783 >> rd 10: Offline availability = 

That was with a folder in case you couldn't tell.
Here it is with a file:

Code: Select all

After New:
21:40:19.254 >> 16: Z:\

After Delete:
21:40:20.340 >> 4: Z:\20091024174018.txt¿
21:40:20.365 >> SHCNE_DELETE
21:40:20.365 >> SHCNE_DELETE: Z:\20091024174018.txt | 20091024174018.txt |  | 

After Undo:
21:40:20.370 >> rd 0: Name = 20091024174018.txt
21:40:20.370 >> rd 1: Original Location = Z:\
21:40:20.370 >> rd 2: Date Deleted = ‎10/‎24/‎2009 ‏‎5:40 PM
21:40:20.370 >> rd 3: Size = 0 bytes
21:40:20.370 >> rd 4: Type = Text Document
21:40:20.370 >> rd 5: Date modified = ‎10/‎24/‎2009 ‏‎5:40 PM
21:40:20.370 >> rd 6: Date created = ‎10/‎24/‎2009 ‏‎5:40 PM
21:40:20.370 >> rd 7: Date accessed = ‎10/‎24/‎2009 ‏‎5:40 PM
21:40:20.370 >> rd 8: Attributes = A
21:40:20.370 >> rd 9: Offline status = 
21:40:20.370 >> rd 10: Offline availability = 

j_c_hallgren
XY Blog Master
Posts: 5824
Joined: 02 Jan 2006 19:34
Location: So. Chatham MA/Clearwater FL
Contact:

Re: Undo/Redo

Post by j_c_hallgren »

Here's what I got:

Code: Select all

22:51:23.855 >> rd 0: Name = laportefamily.jpg
22:51:23.855 >> rd 1: Original Location = C:\DOWNLOADS
22:51:23.855 >> rd 2: Date Deleted = 10/24/2009 06:51 PM
22:51:23.855 >> rd 3: Type = 
22:51:23.855 >> rd 4: Size = 128 KB
22:51:23.855 >> rd 5:  = 
22:51:23.855 >> rd 6:  = 
22:51:23.855 >> rd 7:  = 
22:51:23.855 >> rd 8:  = 
22:51:23.855 >> rd 9:  = 
22:51:23.855 >> rd 10:  = 
And after a delete of that file:

Code: Select all

23:05:20.949 >> 4: C:\DOWNLOADS\laportefamily.jpg¿
So I'm not seeing any cryptic "Dx####.jpg" stuff on W2K...
Still spending WAY TOO much time here! But it's such a pleasure helping XY be a treasure!
(XP on laptop with touchpad and thus NO mouse!) Using latest beta vers when possible.

zer0
Posts: 2673
Joined: 19 Jan 2009 20:11

Re: Undo/Redo

Post by zer0 »

On my Win 7, if it makes any difference, is what I get:

Once deleted

Code: Select all

09:41:04.581 >> 4: D:\Video\TempBurn\New Textfile.txt¿
09:41:04.608 >> SHCNE_DELETE
09:41:04.608 >> SHCNE_DELETE: D:\Video\TempBurn\New Textfile.txt | New Textfile.txt |  | 
Trying Undo

Code: Select all

09:42:27.430 >> rd 0: Name = New Textfile.txt
09:42:27.430 >> rd 1: Original Location = D:\Video\TempBurn
09:42:27.430 >> rd 2: Date Deleted = ‎25/‎10/‎2009 ‏‎9:41 AM
09:42:27.430 >> rd 3: Size = 0 bytes
09:42:27.430 >> rd 4: Item type = Text Document
09:42:27.430 >> rd 5: Date modified = ‎25/‎10/‎2009 ‏‎9:40 AM
09:42:27.430 >> rd 6: Date created = ‎25/‎10/‎2009 ‏‎9:40 AM
09:42:27.430 >> rd 7: Date accessed = ‎25/‎10/‎2009 ‏‎9:40 AM
09:42:27.430 >> rd 8: Attributes = A
09:42:27.430 >> rd 9: Offline status = 
09:42:27.430 >> rd 10: Offline availability = 
Reporting a bug? Have a wish? Got a question? Use search - View roadmap - FAQs: Forum + XY site
Windows 7/10
Always using the latest stable two-decimal build

RalphM
Posts: 1932
Joined: 27 Jan 2005 23:38
Location: Cairns, Australia

Re: Undo/Redo

Post by RalphM »

On my XP SP3:

Code: Select all

12:19:52.546 >> 4: C:\TEMP\New Textfile_01.txt¿
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt
After successful Undo:

Code: Select all

12:19:52.546 >> 4: C:\TEMP\New Textfile_01.txt¿
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt
12:19:52.546 >> SHCNE_DELETE
12:19:52.546 >> SHCNE_DELETE: C:\TEMP\New Textfile_01.txt | New Textfile_01.txt | C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt | Dc52.txt
12:19:52.546 >> mod 4: C:\TEMP\New Textfile_01.txt|C:\RECYCLER\S-1-5-21-4269340281-4223954186-2632510487-1005\Dc52.txt
Funny though, I can't see any difference in the logs contents
Ralph :)
(OS: W11 22H2 Home x64 - XY: Current beta - Office 2019 32-bit - Display: 1920x1080 @ 125%)

admin
Site Admin
Posts: 60357
Joined: 22 May 2004 16:48
Location: Win8.1 @100%, Win10 @100%
Contact:

Re: Undo/Redo

Post by admin »

TheQwerty wrote: After Undo Failed:

Code: Select all

21:28:25.782 >> rd 0: Name = New Folder-01
21:28:25.782 >> rd 1: Original Location = Z:\
21:28:25.782 >> rd 2: Date Deleted = ?10/?24/?2009 ??5:28 PM
21:28:25.783 >> rd 3: Size = 0 bytes
21:28:25.783 >> rd 4: Type = File Folder
21:28:25.783 >> rd 5: Date modified = ?10/?24/?2009 ??5:27 PM
21:28:25.783 >> rd 6: Date created = ?10/?24/?2009 ??5:27 PM
21:28:25.783 >> rd 7: Date accessed = ?10/?24/?2009 ??5:27 PM
21:28:25.783 >> rd 8: Attributes = 
21:28:25.783 >> rd 9: Offline status = 
21:28:25.783 >> rd 10: Offline availability = 
I'm surprised about these question marks in the dates. Are these artifacts of the forum software or do you see them in the original debug log?

Post Reply